search

dask / dask-tutorial

Dask tutorial
https://tutorial.dask.org
BSD 3-Clause "New" or "Revised" License
1.83k stars 702 forks source link

03_array Exercise: Subsample and store should hint you to use `to_zarr` #214

Closed gmiretti closed 2 years ago

gmiretti commented 3 years ago

Currently, the Exercise: Subsample and store in 03_array notebook hint you to use da.to_hdf5, but doing so you stumble with a known bug dask/dask#2488 ( and possible duplicate dask/dask#6482 )

The suggested solution for the exercise in fact uses da.to_zarr to avoid the issue as suggested in https://github.com/dask/dask/issues/6522#issuecomment-675153462

I think that changing the exercise description to match the suggested solution, would be enough and I could do that. If the mantainers are ok, I could push that PR.

I tested this locally using dask 2021.05.1 and binder using dask 2.20

jacobtomlinson commented 2 years ago

Sorry for the lack of response here @gmiretti. Do you still have any interest in pushing that PR?

jsignell commented 2 years ago

We recently revised the tutorial, and this example has changed so that this issue is gone. Thank you for this issue report though!