add join example to dataframe tutorial

dask / dask-tutorial

Dask tutorial

https://tutorial.dask.org

BSD 3-Clause "New" or "Revised" License

1.83k stars 702 forks source link

add join example to dataframe tutorial #227

Closed kori73 closed 2 years ago

kori73 commented 2 years ago

Added a join example to the tutorial as discussed in dask. Since the tutorial is using real data, I have added a holidays dataset to be used in the join. Not sure if the added dependency is okay though.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

quasiben commented 2 years ago

This looks really great. Do you know how big the holidays data set will be ?

quasiben commented 2 years ago

Adding a note setting expectations for users as to why only 3 holidays show up would be good

kori73 commented 2 years ago

This looks really great. Do you know how big the holidays data set will be ?

I have just checked, the holidays dataset has 112 rows.

quasiben commented 2 years ago

Thanks @kori73 I'll plan to merge in tomorrow morning and give other reviewers time to respond

quasiben commented 2 years ago

Thanks again @kori73