search

dask / dask-tutorial

Dask tutorial
https://tutorial.dask.org
BSD 3-Clause "New" or "Revised" License
1.83k stars 702 forks source link

Some notebooks still using old logo #239

Closed jrbourbeau closed 2 years ago

jrbourbeau commented 2 years ago

Copying over @pentschev's comment from https://github.com/dask/community/issues/220#issuecomment-1149107458

Hey all, I noticed the old logo is still used in several pages of https://tutorial.dask.org/, it doesn't look like there's a pattern to which pages still are using the old logo vs those using the new one, so it may be necessary to check one-by-one.

jrbourbeau commented 2 years ago

Good catch @pentschev. It looks like some notebooks are pointing to https://docs.dask.org/en/latest/_images/dask_horizontal.svg (which uses the new logo) while others are pointing to this image in the dask-tutorial repo https://github.com/dask/dask-tutorial/blob/0f213fc240ee2c788dd1230d0f23d72d9e296760/images/dask_horizontal.svg.

We could update the image in this repo to be the new logo, or remove the image from this repo altogether and always point to the https://docs.dask.org/en/latest/_images/dask_horizontal.svg. I'm inclined to go with the second option -- though open to thoughts from others.

@scharlottej13 do you have bandwidth to make these updates?

scharlottej13 commented 2 years ago

Thanks for catching this @pentschev! And thanks @jrbourbeau for the investigation! I'm happy to make these updates.

always point to the https://docs.dask.org/en/latest/_images/dask_horizontal.svg. I'm inclined to go with the second option -- though open to thoughts from others.

I agree this option seems better.

jacobtomlinson commented 2 years ago

We should have one canonical source of truth for the logo. In some places I noticed that I've pointed things at the GitHub avatar for the small logo, so they all got updated when we replaced that, but this still isn't ideal because it isn't obvious.

I think we should aim to document on https://dask.org/brand-guide what the URLs for the logos are. I think right now it just let's you download a zip which is fine but not ideal.

I also wonder if we could choose some neat canonical URLs like https://dask.org/logo/dask_horizonal.svg and point everything there. We could use the docs link for this like you suggested, but I'd been keen to try and keep everything related to branding in WebFlow if we can.

Right now it looks like the main logo on dask.org points to https://assets.website-files.com/627ac9e2b71e64a6a0b76027/627adb72f21c6b4063e05b51_dask-header-logo.svg which seems to be some WebFlow internal CDN implementation detail leaking out. Once we get better access to WebFlow I'm keen to see if we can do better than this.

jsignell commented 2 years ago

I really like the idea of using canonical URLs.

jrbourbeau commented 2 years ago

Yeah, I like the idea of canonical URLs as well. That said, I think updating some of the notebooks here to point to https://docs.dask.org/en/latest/_images/dask_horizontal.svg is a reasonable short-term fix

jsignell commented 2 years ago

Closed by #240

pentschev commented 2 years ago

The image link seems to be broken in https://tutorial.dask.org/00_overview.html (others are correct), it seems like it should have the full URL, rather than a relative path. Also in https://tutorial.dask.org/Homework.html there's no logo, but I'm not sure whether that's intended or not.