dask / dask-tutorial

Dask tutorial
https://tutorial.dask.org
BSD 3-Clause "New" or "Revised" License
1.83k stars 702 forks source link

Update 01_dataframe.ipynb #264

Closed Shadimrad closed 2 years ago

Shadimrad commented 2 years ago

I was looking into this and I thought either I am not fully grasping the fn or this is wrong. Since it is using the file itself rather than the fn. so it should have been either for file in files: or then, later on, had used "fn" instead of "file", right?

Here's a link to the highlighted part: https://tutorial.dask.org/01_dataframe.html#:~:text=for%20fn%20in%20file%3A%0A%20%20%20%20df%20%3D%20pd.read_csv(os.path.join(%27data%27%2C%20%27nycflights%27%2C%20file))%0A%20%20%20%20maxes.append(df.DepDelay.max())

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

dask-bot commented 2 years ago

Beep boop! Here is a Binder link where you can try out this change. Binder

Shadimrad commented 2 years ago

@jrbourbeau Hi, I think the test "docs/readthedocs.org:dask-tutorial — Read the Docs build failed!" might be problematic since the other open issue is also failing this test.

jacobtomlinson commented 2 years ago

The RTD build is experimental right now and is failing, we can safely ignore it.