search

dask / dask-xgboost

BSD 3-Clause "New" or "Revised" License
162 stars 43 forks source link

Add sample_weight and sample_weight_eval_set #74

Closed mmccarty closed 4 years ago

jsignell commented 4 years ago

Is this on the path towards compatibility with xgboost 1.0?

mmccarty commented 4 years ago

No, just some extra kwargs that need to be passed down. This is needed to support versions xgboost < 1.0 that need to scale.

TomAugspurger commented 4 years ago

This looks fine at a glance. I'm tempted to just ignore the CI failures unless @gforsyth is actively working on them and somewhat close to fixing it? At least the new tests aren't failing.

mmccarty commented 4 years ago

Thanks @TomAugspurger I believe he is, but I'm gonna poke at some CI stuff here as well.

mmccarty commented 4 years ago

Just need to add sample_weight to the regressor and double check the docs strings then this will be ready for another look.

mmccarty commented 4 years ago

Ready for another look.

TomAugspurger commented 4 years ago

Thanks @mmccarty