search

dask / dask-xgboost

BSD 3-Clause "New" or "Revised" License
162 stars 43 forks source link

Deprecate `dask-xgboost` #84

Closed jrbourbeau closed 3 years ago

jrbourbeau commented 3 years ago

Closes https://github.com/dask/dask-xgboost/issues/80

cc @TomAugspurger @trivialfis @JohnZed @jakirkham

jrbourbeau commented 3 years ago

Yeah, I'm happy to push a final 0.2.0 release out with this change. Could you add me to PyPI?

I'm also inclined to not worry about the seg fault causing CI to fail and just push things out as is

TomAugspurger commented 3 years ago

Thanks, added to PyPI

trivialfis commented 3 years ago

Thanks for working on this! I will check the segfault after resgistering another github account for logging into circleci...

trivialfis commented 3 years ago

The segfault is caused by old xgboost (0.90) predict function not being thread safe. I ran the tests with latest xgboost and didn't reproduce. It can be safely ignored.

TomAugspurger commented 3 years ago

Thanks all.

jrbourbeau commented 3 years ago

Thanks @TomAugspurger. Pushing out a release now...