search

dask / dask-yarn

Deploy dask on YARN clusters
http://yarn.dask.org
BSD 3-Clause "New" or "Revised" License
69 stars 41 forks source link

rename ncores to nthreads #78

Closed AlJohri closed 5 years ago

AlJohri commented 5 years ago

fixes #77

AlJohri commented 5 years ago

Test failed on:

dask_yarn/tests/test_cli.py::test_cli_submit_and_status[good-SUCCEEDED-Done!] Collecting packages...
Packing environment at u'/home/testuser/miniconda/envs/test-environment' to 'dask-yarn-py27.tar.gz'
[########################################] | 100% Completed | 12.8s
19/07/03 03:08:00 INFO client.RMProxy: Connecting to ResourceManager at master.example.com/172.18.0.4:8032
19/07/03 03:08:00 INFO skein.Driver: Driver started, listening on 38146
FAILED

Any ideas @TomAugspurger?

TomAugspurger commented 5 years ago

Not sure. Hopefully @jcrist can provide some help.

On Wed, Jul 3, 2019 at 12:28 AM Al Johri notifications@github.com wrote:

Test failed on:

dask_yarn/tests/test_cli.py::test_cli_submit_and_status[good-SUCCEEDED-Done!] Collecting packages... Packing environment at u'/home/testuser/miniconda/envs/test-environment' to 'dask-yarn-py27.tar.gz' [########################################] | 100% Completed | 12.8s 19/07/03 03:08:00 INFO client.RMProxy: Connecting to ResourceManager at master.example.com/172.18.0.4:8032 19/07/03 http://master.example.com/172.18.0.4:803219/07/03 03:08:00 INFO skein.Driver: Driver started, listening on 38146 FAILED

Any ideas @TomAugspurger https://github.com/TomAugspurger?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dask/dask-yarn/pull/78?email_source=notifications&email_token=AAKAOIQFNLMCVZBSJUODT3TP5Q2G3A5CNFSM4H5BN5T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDJWMY#issuecomment-507943731, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKAOISBWIW3W7QGEB5ZHSDP5Q2G3ANCNFSM4H5BN5TQ .

jcrist commented 5 years ago

Apologies for the delay here, I've been out-of-office (vacation, then SciPy). Thanks for the fix, I've pushed another commit making this backwards compatible and fixing up some changes for the most recent release of distributed. Will merge and release on tests pass.

jcrist commented 5 years ago

This has now been released as part of version 0.6.2. Thanks for the PR!