Fix clocks on Windows with Python 3.13

dask / distributed

A distributed task scheduler for Dask

https://distributed.dask.org

BSD 3-Clause "New" or "Revised" License

1.55k stars 712 forks source link

Fix clocks on Windows with Python 3.13 #8642

Closed vstinner closed 1 month ago

vstinner commented 1 month ago

Closes #8641.

_WindowsTime is no longer needed on Windows with Python 3.13. On Windows, Python 3.13 now uses GetSystemTimePreciseAsFileTime() for time.time() and QueryPerformanceCounter() for time.monotonic().

https://github.com/python/cpython/pull/116781
https://github.com/python/cpython/pull/116822
[ ] Tests added / passed
[x] Passes pre-commit run --all-files

GPUtester commented 1 month ago

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

github-actions[bot] commented 1 month ago

Unit Test Results

_See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests._

29 files ±0 29 suites ±0 10h 57m 17s :stopwatch: - 2m 19s 4 051 tests ±0 3 950 :white_check_mark: - 1 97 :zzz: ±0 4 :x: +1 55 799 runs ±0 53 634 :white_check_mark: ±0 2 160 :zzz: ±0 5 :x: ±0

For more details on these failures, see this check.

Results for commit f10c398e. ± Comparison against base commit d5edb4e5.

vstinner commented 1 month ago

Thank you for fixing this and congrats for your first dask contribution!

You're welcome :-)