dask / distributed

A distributed task scheduler for Dask
https://distributed.dask.org
BSD 3-Clause "New" or "Revised" License
1.55k stars 712 forks source link

Adding_suspicious_worker #8647

Closed alex-rakowski closed 3 weeks ago

alex-rakowski commented 1 month ago

Adds suspicious workers msg

GPUtester commented 1 month ago

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

github-actions[bot] commented 1 month ago

Unit Test Results

_See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests._

    29 files  ± 0      29 suites  ±0   11h 5m 59s :stopwatch: + 4m 46s  4 056 tests + 5   3 953 :white_check_mark: + 8     97 :zzz: ±0  6 :x:  - 3  55 869 runs  +70  53 698 :white_check_mark: +68  2 163 :zzz: +4  8 :x:  - 2 

For more details on these failures, see this check.

Results for commit f4aaa345. ± Comparison against base commit e4a05450.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both. ``` distributed.shuffle.tests.test_shuffle ‑ test_error_receive ``` ``` distributed.http.scheduler.tests.test_scheduler_http ‑ test_prometheus_collect_task_groups distributed.shuffle.tests.test_rechunk ‑ test_partial_rechunk_taskgroups distributed.shuffle.tests.test_shuffle ‑ test_error_receive[P2PConsistencyError] distributed.shuffle.tests.test_shuffle ‑ test_error_receive[ValueError] distributed.tests.test_spans ‑ test_collections_metadata distributed.tests.test_worker ‑ test_suppress_compute_failure_for_cancelled_tasks ```

:recycle: This comment has been updated with latest results.

fjetter commented 1 month ago

add to allowlist

hendrikmakait commented 3 weeks ago

It looks like test_worker_status_sync and test_log_remove_worker aren't happy :(

Can you please adjust these? (I think you simply have to add the safe keyword and value to the respective expected outputs.)

alex-rakowski commented 3 weeks ago

Those two are now passing

hendrikmakait commented 3 weeks ago

Thanks, @alex-rakowski, and congrats on getting your first contribution merged!