search

dask / distributed

A distributed task scheduler for Dask
https://distributed.dask.org
BSD 3-Clause "New" or "Revised" License
1.55k stars 712 forks source link

Reduce noise from erring tasks that are not supposed to be running #8664

Closed hendrikmakait closed 3 weeks ago

hendrikmakait commented 3 weeks ago

Cancelled tasks emit error logs even though they're not supposed to be running anymore which can become noisy in P2P's consistency mechanism. This PR fixes that.

github-actions[bot] commented 3 weeks ago

Unit Test Results

_See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests._

    29 files  +     1      29 suites  +1   11h 12m 2s :stopwatch: + 1h 41m 53s  4 054 tests  -      4   3 953 :white_check_mark: +   10     97 :zzz:  -   9  4 :x:  - 1  55 841 runs  +10 209  53 676 :white_check_mark: +9 921  2 160 :zzz: +306  5 :x:  - 1 

For more details on these failures, see this check.

Results for commit 6887c608. ± Comparison against base commit 9fae5dac.

This pull request removes 13 and adds 9 tests. Note that renamed tests count towards both. ``` distributed.protocol.tests.test_arrow distributed.protocol.tests.test_collection distributed.protocol.tests.test_highlevelgraph distributed.protocol.tests.test_numpy distributed.protocol.tests.test_pandas distributed.shuffle.tests.test_graph distributed.shuffle.tests.test_merge distributed.shuffle.tests.test_merge_column_and_index distributed.shuffle.tests.test_metrics distributed.shuffle.tests.test_rechunk … ``` ``` distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[False] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[report_args0] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[1] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[False] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[True] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[False] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[report_args0] distributed.tests.test_worker ‑ test_suppress_compute_failure_for_cancelled_tasks ```

:recycle: This comment has been updated with latest results.