dask / distributed

A distributed task scheduler for Dask
https://distributed.dask.org
BSD 3-Clause "New" or "Revised" License
1.55k stars 712 forks source link

More useful warning if a plugin type is provided instead of instance #8689

Closed fjetter closed 2 days ago

fjetter commented 2 weeks ago

The Registering duck-typed plugins is not allowed. warning is confusing if the user accidentally provides the plugin type (which was accepted API in an earlier version)

github-actions[bot] commented 2 weeks ago

Unit Test Results

_See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests._

    29 files  ±    0      29 suites  ±0   11h 9m 26s :stopwatch: + 1h 23m 24s  4 059 tests  -     4   3 954 :white_check_mark: +    5     97 :zzz:  -   9   8 :x: +4  55 911 runs  +7 605  53 735 :white_check_mark: +7 365  2 163 :zzz: +249  13 :x: +8 

For more details on these failures, see this check.

Results for commit f2477326. ± Comparison against base commit 9672121c.

This pull request removes 13 and adds 9 tests. Note that renamed tests count towards both. ``` distributed.protocol.tests.test_arrow distributed.protocol.tests.test_collection distributed.protocol.tests.test_highlevelgraph distributed.protocol.tests.test_numpy distributed.protocol.tests.test_pandas distributed.shuffle.tests.test_graph distributed.shuffle.tests.test_merge distributed.shuffle.tests.test_merge_column_and_index distributed.shuffle.tests.test_metrics distributed.shuffle.tests.test_rechunk … ``` ``` distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[False] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[report_args0] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[1] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[False] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[True] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[False] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[report_args0] distributed.tests.test_client ‑ test_register_worker_plugin_instance_required ```

:recycle: This comment has been updated with latest results.