dask / fastparquet

python implementation of the parquet columnar file format.
Apache License 2.0
787 stars 178 forks source link

Further _from_sequence #899

Closed martindurant closed 1 year ago

martindurant commented 1 year ago

@jrbourbeau , applying the same code change elsewhere, which seems to work on pandas 1.5 too. I am mystified why changing to remove the regression on one spot made the other two spots start to fail - or maybe pandas pushed point update release to both 2x and 1.5x lines.

jrbourbeau commented 1 year ago

Thanks @martindurant. I just confirmed all Dask parquet tests are now passing with Python 3.10 + pandas 1.5.3 + this branch

I am mystified why changing to remove the regression on one spot made the other two spots start to fail

I think it was always failing earlier in the callstack on line 202

martindurant commented 1 year ago

2023.10.1 sdist is on pypi, wheels are building and conda-forge will kick off in due course.

jrbourbeau commented 1 year ago

Thank you @martindurant (cc @mrocklin for visiblity)