search

dask / hdfs3

A wrapper for libhdfs3 to interact with HDFS from Python
http://hdfs3.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
136 stars 40 forks source link

Add versioneer #145

Closed jcrist closed 6 years ago

jcrist commented 6 years ago

Allows checking versions on non-release builds.

martindurant commented 6 years ago

Is this really necessary? Versioneer is pretty annoying in my experience, with rogue _version.py files around and such.

jcrist commented 6 years ago

Rogue _version.py files?

I've had no issues with versioneer, and in my experience it helps when integrating disparate versions from different projects, especially when testing functionality that only exists on master branches. In this specific case I need it to check if the hdfs3 version is after the latest release. Since we use it in most other dask projects I see no harm in including it here.

jcrist commented 6 years ago

Failures are due to need for https://github.com/dask/dask/pull/2894.

jcrist commented 6 years ago

Everything is synced up now, tests pass. Merging.