Closed jcrist closed 6 years ago
cc @brendancol
The py3 test run aborted - does it succeed for you?
It does on the recent release of distributed, but not on distributed master. Looks like https://github.com/dask/distributed/pull/1594 broke something. cc @pitrou, @mrocklin.
If you want to diagnose this a bit further, I suggest:
-s
option to py.test to display all stdout/stderr output immediatelypytest-timeout
plugin to print a traceback for timed out testsOk, after removing the failing dask tests, this now passes.
+1 for the green
Previously this library relied upon duck-typed behavior, instead of following precise schemas for the conversions between ctypes structs and dictionaries of python objects. This led to unicode decode errors, as bytestrings not representing human readable content were being decoded.
This fixes this issue in the following ways:
to_dict
methods to each relevant struct class that knows exactly which fields are bytes and which are strings, and handles all conversions appropriately.ensure_bytes
andensure_string
more strict in terms of input and output.