dask / knit

Deprecated, please use https://github.com/jcrist/skein or https://github.com/dask/dask-yarn instead
http://knit.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
53 stars 10 forks source link

Always set KNIT_LANG, even if envvars passed in #117

Open jcrist opened 6 years ago

martindurant commented 6 years ago

OK, reasonable.

jcrist commented 6 years ago

If it's not set, things fail in the application master here, as a null reference error occurs on this line: https://github.com/dask/knit/blob/master/knit_jvm/src/main/scala/io/continuum/knit/ApplicationMaster.scala#L155. As such, I'm a bit confused why this test passed before. Perhaps changes to the environment variables persisted? I don't really have time right now to debug the tests, but this fix is valid.