search

daskeyboard / q-marketplace

8 stars 0 forks source link

New Applet: Das Ping #11

Closed soluml closed 4 years ago

soluml commented 4 years ago

A different spin on a ping app!

https://github.com/soluml/daskeyboard-applet--dasping

Das Ping Leverages the DasKeyboard's interval and intelligently determines the color gradient. No 3rd party dependencies and super easy to configure!

Mubramaj commented 4 years ago

Hi @soluml , Thank you for your contribution. Your applet will be reviewed and added to the Marketplace. I will notify you here when the applet will be public.

Mubramaj commented 4 years ago

Hi @soluml, I created a new pull request to your repo to remove the image tags from the README due to the markdown interpretor of the Das Keyboard Application that has an issue with the tag.

Can you also please add some tests. You can use a framework like mocha for example. There is example of tests in every daskeyboard applet in the marketplace.

Thank you, Ahmed

soluml commented 4 years ago

Hello!

I've merged the PR. Will also look into adding a few Mocha tests.

Mubramaj commented 4 years ago

Awesome news. Let me know here when it's done.

soluml commented 4 years ago

Alright, tests added. Should be good to go!

soluml commented 4 years ago

@Mubramaj any updates?

Mubramaj commented 4 years ago

Hi @soluml, Your applet have been added to the Das Keyboard Q Marketplace. Thank you for your contribution

Best, Ahmed