daskeyboard / q-marketplace

8 stars 0 forks source link

Updated the ICMP ping applet #12

Closed Conroman16 closed 4 years ago

Conroman16 commented 4 years ago

Hey, I dropped in a pull request on the ICMP ping applet a couple days ago but it doesn't seem to be getting any attention. Might you guys be able to review it and give it a merge? It's based on some suggestions back in April about taking some of the more complex configuration items away from the user.

Also, when I got here I noticed there's a submission for ANOTHER ping applet. I'd be happy to work with that guy to pull in what he actually wants out of a ping applet that this and the Server Ping applet don't already cover, but it seems a little odd to have multiple applets that do the same thing a little differently when we're an open source community and can work together on things.

Anyways, let me know what's up and we can go from there.

Conroman16 commented 4 years ago

Side note: I looked over that Dasping applet a bit more and it appears he just lifted some of the relevant pieces from my original code, reorganized it in a way he likes, and dropped the rest of the functionality while adding some basic gradient logic. I guess the timing was right on me deciding to update my applet then, as I believe my changes address the reasons he made the Dasping applet in the first place and do it in a much cleaner way than publishing a whole new applet into the marketplace. Just my .02 on the topic, as I was surprised to see another ping applet submission when I came here today.