daskos / epos

Write DAG Workflows like epic poems via Mesos, Marathon, Chronos, Spark, Dask
4 stars 1 forks source link

kafka consumer/producer kwarg filtering for odo backend #16

Closed nz87 closed 8 years ago

nz87 commented 8 years ago

Not sure about the location of the code, but I couldn't find a better place for it. Also I had to add some unit tests in the same file with system tests (this forced me to add an init.py also).

How Has This Been Tested?

Unit tests included and gave it a test run w/ the crawler.

Types of changes

kszucs commented 8 years ago

http://stackoverflow.com/questions/3517892/python-list-function-argument-names

kszucs commented 8 years ago

The decorators are not necessary! :)

nz87 commented 8 years ago

They are almost never necessary, but I tought they'd mark the purpose (and result) of the functions better than the function names themselves and I wouldn't wanted to include any kind of cleanup logic in the function body.