dasmikko / strapi-tiptap-editor

A drop-in replacement for the strapi editor
MIT License
64 stars 29 forks source link

fix: update alt in inserted image if media was updated #49

Closed multipliedtwice closed 2 years ago

multipliedtwice commented 2 years ago

Sometimes library doesn't add alt to images. It forces the user to delete and insert the image again. Can we update the alt in inserted images every time the source image is updated?

Also,

image

SalahAdDin commented 2 years ago

@thousandsofraccoons why does we need @tiptap/extension-history in this PR?

@dasmikko could you review it please?

dasmikko commented 2 years ago

This is some nice changes!

@SalahAdDin He states in the first comment, that he includes the history extension, which we do want.

SalahAdDin commented 2 years ago

@dasmikko I found a way to add video component support, I would like to add it to tiptap, could you help me to make a pull request adding it as an extension?

I will try to make a Pull Request and you can suggest me changes, etc.