dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
226 stars 68 forks source link

When you add multiple Blob VCF sources, the same blob is displayed twice #125

Open danvk opened 9 years ago

danvk commented 9 years ago

Here's what my sources array looks like:

var sources = [
    {
      name: 'Genome',
      twoBitURI: 'http://www.biodalliance.org/datasets/hg19.2bit',
      tier_type: 'sequence'
    },
    {
      name: 'VCF1',
      tier_type: 'memstore',
      payload: 'vcf',
      // uri: '/snv.vcf'
      blob: new Blob([vcfBytes1])
    },
    {
      name: 'VCF2',
      tier_type: 'memstore',
      payload: 'vcf',
      // uri: '/snv2.vcf'
      blob: new Blob([vcfBytes2])
    }
];

When I comment out the blob keys and uncomment the uri keys, I see the expected result: screen shot 2014-10-28 at 5 39 35 pm

But when I use blobs, I see the same thing twice: screen shot 2014-10-28 at 5 39 57 pm

I can verify that vcfBytes1 != vcfBytes2.

Full code here: https://gist.github.com/danvk/a3f63e266bb319c08ab9

dasmoth commented 9 years ago

The Blob support is really expecting File objects, not generic blobs. Try setting the name property on your blobs to (different) strings and all should be well.

I'll tweak the caching code so that it doesn't assume blobs with no names are all the same!

On Tuesday, October 28, 2014, Dan Vanderkam notifications@github.com wrote:

Here's what my sources array looks like:

var sources = [ { name: 'Genome', twoBitURI: 'http://www.biodalliance.org/datasets/hg19.2bit', tier_type: 'sequence' }, { name: 'VCF1', tier_type: 'memstore', payload: 'vcf', // uri: '/snv.vcf' blob: new Blob([vcfBytes1]) }, { name: 'VCF2', tier_type: 'memstore', payload: 'vcf', // uri: '/snv2.vcf' blob: new Blob([vcfBytes2]) }];

When I comment out the blob keys and uncomment the uri keys, I see the expected result: [image: screen shot 2014-10-28 at 5 39 35 pm] https://cloud.githubusercontent.com/assets/98301/4817659/fd2673fc-5eea-11e4-9333-87117c6ad5b8.png

But when I use blobs, I see the same thing twice: [image: screen shot 2014-10-28 at 5 39 57 pm] https://cloud.githubusercontent.com/assets/98301/4817658/fd246ba2-5eea-11e4-9838-4e29ee3c6e2a.png

I can verify that vcfBytes1 != vcfBytes2.

Full code here: https://gist.github.com/danvk/a3f63e266bb319c08ab9

— Reply to this email directly or view it on GitHub https://github.com/dasmoth/dalliance/issues/125.