search

dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
226 stars 68 forks source link

adding bower support #172

Open Traksewt opened 8 years ago

Traksewt commented 8 years ago

added bower component file. License property needs to be updated.

dasmoth commented 8 years ago

Thanks for this.

However (and possibly I'm misunderstanding this -- I don't use bower myself) I'm not clear how the compilation step is meant to run in order to build dalliance-all.js and worker-all.js. When I looked into this previously, the done thing appeared to be to check compiled javascript assets into the project's main git repository (which I'm very reluctant to do, because including a bunch of old compiled versions will end up bloating git checkouts for everyone)

Potentially there could be a separate bower-specific repository?

Or am I missing something?

doomedramen commented 8 years ago

I have 'dalliance-dist' on bower at the moment but I am unable to update it as dalliance fails to build for me on recent versions of node+npm

dasmoth commented 8 years ago

@wookoouk sorry about this, the sands seem to have shifted rather a lot underneath the original build system. I'm updating it at the moment.

dasmoth commented 8 years ago

I've updated the dependencies and build system. This ended up requiring a change from Google Closure Compiler -> Uglify (which I was a little nervous about, but output size hasn't changed much and I can't see any evidence of performance regressions).

Give me a shout if you see any problems. I'll switch to doing releases (which will probably be called 0.14.x) using this system after Christmas.

doomedramen commented 8 years ago

I have update 'dalliance-dist' to use the latest changes.

install it with bower install dalliance-dist --save