search

dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
226 stars 68 forks source link

Renderer cleanup #202

Closed dasmoth closed 7 years ago

dasmoth commented 7 years ago

With the new pluggable rendering system merged, it would be good to remove the old renderer rather than risking them diverging.

One issue with this is that it will break the current renderer-testing scheme. As discussed on #200, a reasonably solution might be to test the renderer against a reference rendering (probably in the form of JSON-serialized scene graph)

dasmoth commented 7 years ago

I've changed the testing scheme to compare against a pre-serialised scene graph, which seems to be working pretty nicely, and means we've been able to ditch old-renderer.js.

However, it turns out that the SVG and Image export code still fall back to the old rendering code exported by feature-draw.js. So still need to do a little more refactoring before we can ditch it completely...