search

dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
226 stars 68 forks source link

Fix uncompressed bed parser #224

Closed max-l closed 6 years ago

max-l commented 6 years ago

fix for #223

dasmoth commented 6 years ago

Thanks for catching this! Have pulled the block-length commit now.

There's a second commit in this pull request, relating to a mechanism for inhibiting the "feature info" popups. Happy to add something like that, but I'm a bit uncomfortable with adding meaning to the return values of functions where previously there was none. As an alternative, how about adding a method on the FeatureInfo objects, i.e.

          featureInfo.inhibitPopup();

(Would also be curious to hear more about your use case for custom popups, if that's something you can share).

dasmoth commented 6 years ago

I've just added a featureInfo.inhibitPopup() as discussed above: https://github.com/dasmoth/dalliance/commit/2d402001c92b39e31844486e021eeda71b8fa4a1

max-l commented 6 years ago

@dasmoth the purpose of my inhibitPopup() function is that I wanted to have my own popups. I know Dalliance provides hooks for modifying the popups, but in my use case, the popup was of a radically different structure, so I only wanted to get notified when a browser element was clicked and show my own popup.