search

dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
227 stars 68 forks source link

https support #38

Closed doomedramen closed 10 years ago

doomedramen commented 10 years ago

Currently there are hardcoded external assets that go over http, such as:

http://www.biodalliance.org/release-0.10/img/loader.gif and http://www.biodalliance.org/release-0.10/css/dalliance-scoped.css

could these please be changed to // to allow http + https support

doomedramen commented 10 years ago

Please note: http://netdna.bootstrapcdn.com/font-awesome/4.0.3/css/font-awesome.css breaks buttons for me (over https -> http)

dasmoth commented 10 years ago

The use of fontawesome assets is an experiment and (if we keep them) the deployment mechanism will definitely change before release. But for now, you should just be able to change that to an https URL (top of browser-ui.js).

(I did try a protocol-relative URL but it didn't work for some reason -- will investigate!)

doomedramen commented 10 years ago

Thanks dasmoth, I will change it locally for now.

doomedramen commented 10 years ago

...oh, The following change worked for me:

document.head.appendChild(makeElement('link', '', {rel: 'stylesheet', href: '//netdna.bootstrapcdn.com/font-awesome/4.0.3/css/font-awesome.css'}));

Not sure why it didn't for you.

dasmoth commented 10 years ago

https://www.biodalliance.org/ is -- somewhat belatedly -- up-and-running now.

The default asset prefix will be protocol-relative in releases 0.11.10 and 0.12.x