search

dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
226 stars 68 forks source link

Unable to read in TwoBit file #59

Closed mkempenaar closed 10 years ago

mkempenaar commented 10 years ago

Hi,

With the latest 0.12.0pre2 I am unable to use a TwoBit as reference genome.

The following error appears: Uncaught ReferenceError: readIntBE is not defined

which I would have expected at line 15, after var readInt = bin.readInt;

dasmoth commented 10 years ago

Sorry about this, a bit of code got lost during refactoring when we switched to the new browserify build system.

Would you mind if I placed the big-endian .2bit file you previously sent me somewhere at least semi-public, so that we can use it in the Dalliance test suite -- since big-endian .2bits are quite rare, I think automated testing would be quite helpful to avoid any future bit-rot!

mkempenaar commented 10 years ago

Of course, no problem at all!

Thanks again.

mkempenaar commented 10 years ago

Working after latest commit, thanks!

dasmoth commented 10 years ago

Excellent -- have just added a test for this, so hopefully won't get broken again!

Thanks for your help in tracking it down.