search

dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
226 stars 68 forks source link

Regarding Uncollapsing Super Groups #66

Closed ymen closed 10 years ago

ymen commented 10 years ago

Hi Thomas and Dalliance developers,

Thanks again for the awesome program.

I was experimenting with turning off collapsing of super groups in the genes track (by setting the flag "collapseSuperGroups": false)

This triggers an error in glyph drawing relating to an issue with registering glyphs screen shot 2014-06-27 at 10 27 13 am

Trivial change: check before registerGlyph

The uncaught exception boils down to a registerGlyph call, and seems to be trivially solved by doing a check around line 402 of glyph.js

from 

oc.registerGlyph(this);

to 

if(oc)
     oc.registerGlyph(this);

Not sure whether this is the best way to solve the problem, but just wanted to share the issue with you.

Thanks! Best, Yifei

dasmoth commented 10 years ago

Thanks for spotting this. The OverlayCanvas parameter is supposed to be propagated right down the render tree, but was getting lost in a few cases. Fixed now.