Closed ymen closed 10 years ago
Hi Thomas and Dalliance developers,
Thanks again for the awesome program.
I was experimenting with turning off collapsing of super groups in the genes track (by setting the flag "collapseSuperGroups": false)
"collapseSuperGroups": false
This triggers an error in glyph drawing relating to an issue with registering glyphs
The uncaught exception boils down to a registerGlyph call, and seems to be trivially solved by doing a check around line 402 of glyph.js
registerGlyph
glyph.js
from
oc.registerGlyph(this);
to
if(oc) oc.registerGlyph(this);
Not sure whether this is the best way to solve the problem, but just wanted to share the issue with you.
Thanks! Best, Yifei
Thanks for spotting this. The OverlayCanvas parameter is supposed to be propagated right down the render tree, but was getting lost in a few cases. Fixed now.
Hi Thomas and Dalliance developers,
Thanks again for the awesome program.
I was experimenting with turning off collapsing of super groups in the genes track (by setting the flag
"collapseSuperGroups": false
)This triggers an error in glyph drawing relating to an issue with registering glyphs![screen shot 2014-06-27 at 10 27 13 am](https://cloud.githubusercontent.com/assets/7988161/3415749/90ae5824-fe24-11e3-95e4-8e8592baeac9.png)
Trivial change: check before registerGlyph
The uncaught exception boils down to a
registerGlyph
call, and seems to be trivially solved by doing a check around line 402 ofglyph.js
from
to
Not sure whether this is the best way to solve the problem, but just wanted to share the issue with you.
Thanks! Best, Yifei