search

dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
226 stars 68 forks source link

Support for IE11 #84

Closed andreasprlic closed 10 years ago

andreasprlic commented 10 years ago

Hi,

One of my users complained that Dalliance does not work on IE11 (latest version). Please see attached screenshots.

dalliance_ie11 ie11version If I can help anything to debug this, please let me know!

Andreas

mz2 commented 10 years ago

That's a feature, not a bug :trollface:

On 25 Jul 2014, at 23:35, Andreas Prlic notifications@github.com wrote:

Hi,

One of my users complained that Dalliance does not work on IE11 (latest version). Please see attached screenshots.

If I can help anything to debug this, please let me know!

Andreas

— Reply to this email directly or view it on GitHub.

andreasprlic commented 10 years ago

Thanks Mattias, I could have almost seen that one coming ;-) You could of course close this as a won't fix, however this has emerged during testing of the upcoming new Gene View at http://beta.rcsb.org/pdb/gene/HBA1 . IE (all versions) still has about 12% of the overall traffic at the RCSB (IE11 has about 5%) which still means thousands of potential users that can't use Dalliance currently. As such, if there is an easy fix, would be great (but no pressure).

dasmoth commented 10 years ago

Annoying -- it worked last time I tested, but I admit I don't test IE terribly often... (should find some way to automate this, or at least do it in a VM, so I don't have to scramble around finding mice and keyboards for the Windows machine...)

The browser component isn't actually crashing, but we're hitting a stylesheet glitch which is causing it to collapse to zero height. If you press one of the toolbar buttons to open the side panel (track adder, track editor, etc.) you'll see it's working fine.

I'll see if I can debug the stylesheet this afternoon...

dasmoth commented 10 years ago

This seems to be a case of IE11's layout engine struggling with nested flexboxes. This is a somewhat-known issue (see this).

The most likely solution right now is to disable the 0.12 tier-pinning functionality on IE. This requires an extra layer of nested flexboxes in the layout. It's somewhat annoying to lose this, but better than being completely non-functional!

andreasprlic commented 10 years ago

Thanks for tracking this down so quickly and on the weekend!

dasmoth commented 10 years ago

Fixed in 0.12.5