search

dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
226 stars 68 forks source link

Replace zoom slider #88

Closed dasmoth closed 9 years ago

dasmoth commented 10 years ago

The current we use as a zoom slider has at least two major problems:

  1. It doesn't give any feedback about the toggle-zoom (space-bar) functionality, making that functionality hard to discover and meaning you have no indication of what hitting space will do at any given moment.
  2. It looks super-ugly in Internet explorer, and there seems to be no way to style it even remotely like what we get on other platforms short of re-implementing it.

Therefore, I suggest implementing a new slider that looks reasonably close to a standard but has feedback for toggle-zooming (maybe a greyed-out second thumb?).

The polyfill code we used to use to get sliders on Mozilla may be useful here.

dasmoth commented 9 years ago

Done

andreasprlic commented 9 years ago

this looks great!

Traksewt commented 9 years ago

I like the idea. Though I'm not sure if I'm missing some stylesheets, as after I've updated the code, the new 'slider-label' text is listed going down the page instead of horizontally (I assume). The dalliance code is automatically using the public stylesheets (http://www.biodalliance.org/release-0.13/css/dalliance-scoped.css). Are these stylesheets out of sync with the current dev version ?

image

dlrice commented 9 years ago

In adding the single base highlighter ruler in #111 I have added some classes which are not in the public stylesheets which would at least explain why the location text is all the way to the left and not in the centre.

dasmoth commented 9 years ago

@Traksewt is right, there was a stale stylesheet in the release-0.13 directory. I try to keep the "next release" resources directory reasonably up to date, but it does sometimes slip for a week or two -- if you're using a development version of Biodalliance seriously, it's probably worth keeping your own copy of the resources (css, fonts, help) and setting the prefix option accordingly.

Traksewt commented 9 years ago

great thanks guys, I didn't realise the prefix option for stylesheets. The public css is looking good now, and the slider is looking great.

dasmoth commented 9 years ago

Sounds like there's a need for better documentation regarding how assets get located, have opened https://github.com/biodalliance/dalliance-web/issues/5 to track.