dasmoth / dalliance

Interactive web-based genome browser.
http://www.biodalliance.org/
BSD 2-Clause "Simplified" License
226 stars 68 forks source link

Catching for undefined before setting .bumped property? #95

Closed ymen closed 10 years ago

ymen commented 10 years ago

The changes introduced by recent changes to bumped property setting seem to allow setting the property to undefined on occasion, which produces undesired visualization effects, like this:

screen shot 2014-08-26 at 2 15 23 pm

If I do a log inside this if loop, we can see that it's setting the bumped property to undefined.

screen shot 2014-08-26 at 2 16 37 pm

Can be trivially solved by checking for undefined value, to get back the desired visualization. screen shot 2014-08-26 at 2 17 21 pm

I think this is probably WIP and part of a larger transition for styling and probably will be solved further down the line, but just wanted to let you know about this so it's not lost.

dasmoth commented 10 years ago

Should be fixed now, thanks.