search

dasniko / testcontainers-keycloak

A Testcontainer implementation for Keycloak IAM & SSO.
Apache License 2.0
341 stars 53 forks source link

Move to datafaker #63

Closed snuyanzin closed 2 years ago

snuyanzin commented 2 years ago

Since javafaker is hardly supported there is a fork of javafaker - datafaker which is evolving keeping javafaker APIs. The PR suggests to move to datafaker

dasniko commented 2 years ago

Thanks for this PR, but where are the benefits? I'm using the library just as an example on how to integrate 3rd party dependencies, so this even could have been a helloworld-library which just returns a static string.

dasniko commented 2 years ago

Seems that there is no real interest/need to use this PR, besides that the PR opener is a committer of the suggested library, which he didn't mention. Closing this PR though.