search

dasniko / testcontainers-keycloak

A Testcontainer implementation for Keycloak IAM & SSO.
Apache License 2.0
328 stars 51 forks source link

use current thread context loader for load resources #68

Closed gaetancollaud closed 2 years ago

gaetancollaud commented 2 years ago

This address the first issue of #64

gaetancollaud commented 2 years ago

Wait ! Don't merge it. It seems like I've broken the tests. I will investigate.

gaetancollaud commented 2 years ago

I fixed the test, but the fix is kinda stupid...

I tried all possibilities (with ThreadContext and classloader), but I was not able to find one solution that fits everything.

dasniko commented 2 years ago

An alternative could be to leave it as is for now and wait for KC 18, as then the auto-import of realms is available again directly by Keycloak and I can remove my workaround with using the KC admin client/api.

gaetancollaud commented 2 years ago

An alternative could be to leave it as is for now and wait for KC 18, as then the auto-import of realms is available again directly by Keycloak and I can remove my workaround with using the KC admin client/api.

Actually, if you know that you will remove this part later, it doesn't hurt to add my dirty fix. So I can go ahead with the other issue (Quarkus arc container not started).