daspartho / SpotiByeAds

Skip spotify ads by automatically restarting application when ad plays
GNU General Public License v3.0
286 stars 41 forks source link

Issues with manjaro #21

Open ceceba223 opened 3 years ago

ceceba223 commented 3 years ago

When running on manjaro the program doesn't close spotify. It still opens a new window tho. There for ads aren't skipped. Specs:

OS: Manjaro Linux x86_64 
Kernel: 5.10.53-1-MANJARO 
Shell: bash 5.1.8 
WM: i3 
Terminal: kitty 
CPU: AMD Ryzen 7 3700X (16) @ 3.600GHz 
GPU: NVIDIA GeForce GTX 1660 
Memory: 2875MiB / 15990MiB 
AnonymouX47 commented 3 years ago

What's the name of the Spotify process?

jedistack commented 3 years ago

@AnonymouX47 in Windows file directory it's C:/Users/[username]/AppData/Roaming/Spotify/Spotify.exe you can use this instead of shutil.which("Spotify") if that command isn't working, which it wasn't for me, just dont move spotify and that should work

AnonymouX47 commented 3 years ago

Already fixed and merged into the main repo... you can do a git pull to reflect the changes on your side.

See #29

AnonymouX47 commented 3 years ago

@ceceba223 Is it working fine on Manjaro now?

AnonymouX47 commented 3 years ago

@ceceba223 Did you install Spotify from the snap store?

If so, please, simply add /snap/bin/ to your $PATH. This will make shutil.which() to find the executable. See here. Creating another case in the script for snap installs would be unnecessary.

I'll probably add info about this to the README.

Thanks.

AnonymouX47 commented 3 years ago

Sorry, was a mistake...