Fixed dependency installation and some platform-dependency issues.

daspartho / SpotiByeAds

Skip spotify ads by automatically restarting application when ad plays

GNU General Public License v3.0

284 stars 41 forks source link

Fixed dependency installation and some platform-dependency issues. #29

Closed AnonymouX47 closed 3 years ago

AnonymouX47 commented 3 years ago

Failure in Dependency installation was leading to an infinite loop.
Improper platform names were being used.
PID was previously hard-coded, but it's never constant.

AnonymouX47 commented 3 years ago

Note that PATH for windows is still left out. Deliberately did this due to different installation sources on windows. I think using a config file where the user can enter the path to the executable would be the best option on windows.

AnonymouX47 commented 3 years ago

@jobveldhuis I just made the change you suggested.

jobveldhuis commented 3 years ago

@jobveldhuis I just made the change you suggested.

I don't think you should wrap your imports in a try/catch. Instead, just import and let the Python environment handle any ImportErrors thrown. While we're on this subject, why are we both importing the spotipy module and some keywords out of the spotipy module, instead of just doing one or the other?

AnonymouX47 commented 3 years ago

I don't think you should wrap your imports in a try/catch.

Well... from the little experience I've had with projects having third-party dependencies... imports are mostly handled as such just to give the user a neater message and to make the program exit gracefully.

AnonymouX47 commented 3 years ago

Tested on both Linux and Windows (Not Microsoft Store version)... Works totally fine on both.

Can someone please test on MacOS and give a feesback.