search

daspartho / SpotiByeAds

Skip spotify ads by automatically restarting application when ad plays
GNU General Public License v3.0
284 stars 41 forks source link

A simple fix for issue #44 #48

Closed The-Glit-ch closed 3 years ago

The-Glit-ch commented 3 years ago

Instead of pinging Spotify every second just to check if an ad is playing. We can simply get the song length and wait that amount of time and then check if an ad is playing

(#44)

The-Glit-ch commented 3 years ago

Update:

The-Glit-ch commented 3 years ago

@AnonymouX47 Everything good here?

daspartho commented 3 years ago

Great!

AnonymouX47 commented 3 years ago

@The-Glit-ch Next time, probably try to make your commit messages briefly explain exactly what changes or additions were made 🙏🏾 ... like "Changed AD poll interval" instead of "update main.py".

Kudos anyways 👍🏾

AnonymouX47 commented 3 years ago

@daspartho i was just about commenting that @The-Glit-ch should've created a separate branch for this change... It doesn't cause a mess really except for @The-Glit-ch. Their main branch will now be inconsistent with upstream's main.

Also, the fix still needed some changes :)

AnonymouX47 commented 3 years ago

@The-Glit-ch I just tested the change now and realised the method wasn't called as causes a fatal error, meaning you didn't test it.

Please always test a change before opening a PR... It was for reasons like this that i asked you to open the PR as a draft, so it can be properly reviewed.

@daspartho Please, the more changes are reviewed, the better... there should be no rush in merging PRs, for the good of everyone. 🙏🏾 Everyone is prone to mistakes,

By the way, there's no need to revert the change, I've already fixed it, i'll open a PR very soon :)