Closed kkiesling closed 1 year ago
It also appears that a maintainer needs to release it to run on CI
Merging #18 (2cf4cd9) into develop (b0c80b2) will not change coverage. The diff coverage is
100.00%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## develop #18 +/- ##
========================================
Coverage 79.57% 79.57%
========================================
Files 47 47
Lines 10440 10440
========================================
Hits 8308 8308
Misses 2132 2132
Flag | Coverage Δ | |
---|---|---|
unittests | 79.57% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
dassh/reactor.py | 88.08% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
The codecov
package is no longer available. Switching to coverage
per recommendation here. Python 3.6 doesn't have newest coverage version available hence the version requirements.
This is ready for review/merge @MilosAtz
The DASSH output file contains a unicode character (check mark) in one of the tables. Right now, no specific text encoding is specified for this file. Generally Python can figure out if it is ASCII or Unicode or other, but sometimes it struggles. In the PyARC workflow with some updated python environment packages, I am finding that it can no longer properly identify the file as needing unicode encoding rather than ascii and it fails to generate the output file because it doesn't know how to write the check mark unicode character. This one-line fix should fix that error.
It also appears the develop and master branches here are out of sync and need to be fixed before this is merged.