search

dat-ecosystem-archive / DEPs

Dat Enhancement Proposals. Contains all specs for the Dat protocol, including drafts. [ DEPRECATED - see https://github.com/hypercore-protocol/hypercore-proposals for similar functionality. More info on active projects and modules at https://dat-ecosystem.org/ ]
https://dat-ecosystem.github.io/DEPs
166 stars 17 forks source link

Bug: Incorrect entry size for bitfield in DEP-0009 #68

Open smoyer64 opened 3 years ago

smoyer64 commented 3 years ago

DEP-0009 states that the entry size for the bitfield file should be 3328 (0x0d00) but the hypercore files I've found all use 3584 (0x0e00) for the entry size in these files.

bnewbold commented 3 years ago

This may be because newer hypercore (the implementation) has diverged from this DEP?

I checked some 2017-era .dat/*.bitfield files and they are 3360 bytes, which is consistent with a 32 byte SLEEP header plus 3328 bitfield entry size.

smoyer64 commented 3 years ago

I found a reference elsewhere that points to https://github.com/hypercore-protocol/hypercore/pull/184 so I suspect that you might be right. So should hyper be considered to be a superceding implementation of dat?