search

dat-ecosystem-archive / dat-desktop

Peer to peer data syncronization [ DEPRECATED - More info on active projects and modules at https://dat-ecosystem.org/ ]
https://dat.foundation
MIT License
648 stars 69 forks source link

Run the `watch` task in process #187

Closed juliangruber closed 7 years ago

juliangruber commented 7 years ago

This way it's always keeping bundles up to date in dev, and no need to keep a second terminal open

yoshuawuyts commented 7 years ago

Prior art https://github.com/yoshuawuyts/playground-bankai-in-electron

yoshuawuyts commented 7 years ago

Some stuff I ran into:

juliangruber commented 7 years ago

We could also instead of serving bundles via http run the watch task and make it write the bundle to disk, which would be the simplest change for now, albeit less flexible

juliangruber commented 7 years ago

haven't figured out how to exclude watchify, browserify and the like (dev deps) from the production bundle - this is a hyper optimization tho, and unless we come up with something trivial not worth spending time on I reckon

we could do something like, on bundle copy the app folder to a temporary folder, remove dev deps from package.json, re install deps, bundle

yoshuawuyts commented 7 years ago

Oh actually, we could do npm prune --production I think to remove all dev deps :D - saves us a whole bunch of reinstalling - def digging this idea

On Mon, Jan 30, 2017 at 1:13 PM Julian Gruber notifications@github.com wrote:

haven't figured out how to exclude watchify, browserify and the like (dev deps) from the production bundle - this is a hyper optimization tho, and unless we come up with something trivial not worth spending time on I reckon

we could do something like, on bundle copy the app folder to a temporary folder, remove dev deps from package.json, re install deps, bundle

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/datproject/dat-desktop/issues/187#issuecomment-276192383, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlevDHR_am9VQY6irggTXdzZgtug1zks5rXlKJgaJpZM4LxcOk .

juliangruber commented 7 years ago

PR in #189