dat-ecosystem-archive / multidat

Manage multiple dat instances [ DEPRECATED - More info on active projects and modules at https://dat-ecosystem.org/ ]

MIT License

22 stars 6 forks source link

add errors to dat list instead of failing completely #7

Closed juliangruber closed 7 years ago

juliangruber commented 7 years ago

this is required for https://github.com/datproject/dat-desktop/issues/284

This way you can check dat instanceof Error and render UI properly.

This is a breaking change.

codecov-io commented 7 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          62     64    +2     
=====================================
+ Hits           62     64    +2

Impacted Files	Coverage Δ
index.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f7bc15...ccdc013. Read the comment docs.

yoshuawuyts commented 7 years ago

Tbh I'm slightly confused by this interface. Perhaps adding some docs might help? I'm guessing this just pushes an error into the array of dats?

juliangruber commented 7 years ago

Tbh I'm slightly confused by this interface. Perhaps adding some docs might help? I'm guessing this just pushes an error into the array of dats?

Oh yeah we should definitely add docs for this. Will do.

juliangruber commented 7 years ago

@yoshuawuyts i added some docs, do you think this is clear now?

juliangruber commented 7 years ago

tests failed because of the known leveldb issues

juliangruber commented 7 years ago

4.0.0