send upstream PR to rabin-cdc

dat-ecosystem-archive / rabin

node native addon for rabin fingerprinting data streams [ DEPRECATED - More info on active projects and modules at https://dat-ecosystem.org/ ]

148 stars 22 forks source link

Open max-mapper opened 8 years ago

max-mapper commented 8 years ago

We should contribute the rabin modifications to the upstream source: https://github.com/fd0/rabin-cdc/issues/1

green-coder commented 8 years ago

How about first merging #4 into this project and then prepare a PR for fd0/rabin-cdc#1 ?

Also, you might want to expose the polynom to the JS API (with get/set modifiers) in case the default doesn't fit some user's use case.

max-mapper commented 8 years ago

@green-coder yes that sounds good, I mentioned that here actually https://github.com/fd0/rabin-cdc/issues/1#issuecomment-170279016

GamePad64 commented 8 years ago

And then you will be able to make src/ a submodule, synchronized with rabin-cdc upstream