Improve documentation of `ip`-field (Orig: Does not work with version 1.34.2?)

datMaffin / homebridge-tesla-powerwall

Homebridge Plugin for the Tesla Powerwall

ISC License

21 stars 11 forks source link

Improve documentation of `ip`-field (Orig: Does not work with version 1.34.2?) #13

Closed Praktiker closed 4 years ago

Praktiker commented 4 years ago

I really would like to use the plugin, it also appears in the HomeKit app but says: no answer or e.g. Grid Feed (not supported). Any ideas?

Praktiker commented 4 years ago

Sorry, it needs the IP, otherwise it seems not to work. So don't mind my comment. :-)

datMaffin commented 4 years ago

No problem; yeah the ip field is listed in the optional documentation section. The reasoning is that the ip field has a default value of 127.0.0.1 (localhost). However, using localhost as the default does not make much sense in practice.

[ ] Improve documentation: The ip field should move from the optional to the mandatory section.
[ ] Maybe(?): Remove default value from implementation.