added tests for branching in tables _join

data-8 / datascience

A Python library for introductory data science

https://www.data8.org/datascience/

BSD 3-Clause "New" or "Revised" License

626 stars 295 forks source link

added tests for branching in tables _join #613

Closed rwmehta closed 5 months ago

rwmehta commented 5 months ago

[X] Wrote test for feature [ ] Added changes to CHANGELOG.md

Changes proposed: Added tests for if and if not branches in tables _join method as requested in issue #476 . Ensures the method returns None when either table has no rows, and matches the label when "other_label" is not provided.

coveralls commented 5 months ago

coverage: 94.976%. remained the same when pulling 572b08f9b6e7aa61ecc12c402fa2938e590b098b on rwmehta:rwmehta/test-coverage-table-join into 0c82a194745924228d76d6b075677b2adc6e5094 on data-8:master.

davidwagner commented 5 months ago

This doesn't seem to increase test coverage. I think these cases are already covered by other pre-existing test cases: empty tables by test_join_no_rows(), and no 3rd argument to join by many other test cases. But OK, why not, more tests can't hurt. Thanks for the contribution.