search

data-apis / array-api-compat

Compatibility layer for common array libraries to support the Array API
https://data-apis.org/array-api-compat/
MIT License
69 stars 22 forks source link

Ensure that Jax float0 array is recognized #130

Closed NeilGirdhar closed 4 months ago

NeilGirdhar commented 4 months ago

See https://github.com/google/jax/issues/20620.

NeilGirdhar commented 4 months ago

This is intended to be a temporary solution until Jax (ideally) makes these arrays into Jax arrays. I don't see any reasonable way for clients to work around this unless this is fixed on the library side.

NeilGirdhar commented 4 months ago

(Error appears to be unrelated to this pull request.)

asmeurer commented 4 months ago

This looks good. Can you add a test.

NeilGirdhar commented 4 months ago

Great, I added a test.

asmeurer commented 4 months ago

The tests failure should be fixed by my suggestion, and the test suite failure should be fixed by https://github.com/data-apis/array-api-compat/pull/131.

NeilGirdhar commented 4 months ago

(Done.)