search

data-apis / array-api-compat

Compatibility layer for common array libraries to support the Array API
https://data-apis.org/array-api-compat/
MIT License
69 stars 22 forks source link

Wrap fft for dask #139

Open lithomas1 opened 3 months ago

lithomas1 commented 3 months ago

There's some failures relating to the expected dtype on older numpy versions.

asmeurer commented 3 months ago

The wrappers in common should already be handling the dtype difference. It looks like the norm keyword isn't working, though.

lithomas1 commented 1 week ago

Going to pick this up again this week.

Thanks for not closing.

lithomas1 commented 1 week ago

This should be ready for a look now.

Tests are passing with dask main. (this should be mergeable whenever dask cuts its next release).

asmeurer commented 3 days ago

Does dask still require the wrappers here? The only thing they do for NumPy is fix upcasting for 32-bit types, which has been fixed in NumPy 2.0. If the next version of dask has the NumPy 2.0 behavior then no wrapping is necessary at all.