Closed tylerjereddy closed 6 months ago
I don't think we can really emulate copy=False
in NumPy 1.26, hence the NotImplementedError. If NumPy main now actually supports copy=False we should update that code to pass it through for NumPy >= 2.0.
Should be fixed by gh-12. Since the NumPy change got merged in a way that wasn't backwards-compatible, this is breaking SciPy tests now (and probably tests of other users of this package). Even if that is addressed in NumPy, a missing copy
keyword will still emit a warning, which is still going to break the SciPy test suite. So it'd be nice to do a release with this issue fixed very soon.
Probably not surprising; in https://github.com/scipy/scipy/pull/20172 I noticed what looks like a requirement for at least a small
copy
argument pass-through shim with NumPymain
here because of (currently) a single test in SciPy. In that PR I was able to patch similar errors with fairly crudecopy=None
pass-through type shims, though in this library it may actually need to do something useful (the intended purpose) if thecopy
arg really needs to be respected I suppose.