data-apis / array-api-strict

Strict implementation of the Python array API (previously numpy.array_api)
http://data-apis.org/array-api-strict/
Other
7 stars 4 forks source link

Support `copy` keyword in `__array__` method #12

Closed rgommers closed 6 months ago

rgommers commented 6 months ago

Closes gh-11

rgommers commented 6 months ago

The one failure is unrelated (that's the test_solve one), but it cancelled a bunch of test jobs.

asmeurer commented 6 months ago

Tests should be fixed by https://github.com/data-apis/array-api-strict/pull/14

asmeurer commented 6 months ago

Is this a change that any library that implements __array__ will have to make?

rgommers commented 6 months ago

Is this a change that any library that implements __array__ will have to make?

Yes indeed - missing copy or dtype keywords from the __array__ signature will emit a UserWarning in 2.0, and will probably be a deprecation later.