search

data-apis / array-api-tests

Test suite for the PyData Array APIs standard
https://data-apis.org/array-api-tests/
MIT License
64 stars 41 forks source link

database functionality(optional) for storing hypothesis cache #146

Closed Aarsh2001 closed 2 years ago

Aarsh2001 commented 2 years ago

Hi, these changes enable the Array API test suite to be run as part of a CI solution for an adhering framework, with full hypothesis features including database usage, which are essential for maximum the effectiveness and efficiency of the testing across multiple commits.

asmeurer commented 2 years ago

I would prefer if this sort of thing could be done without having to edit conftest.py. Maybe that's a feature request for hypothesis. Anyway, if we do add this, I don't think it should be added in requirements.txt.

Aarsh2001 commented 2 years ago

Can we not do pytest command line arguments for this?, have another CI flag maybe. In that case i don't think there would be any hardcoding, although it would still change conftest. Looking forward to your thoughts.

honno commented 2 years ago

Can we not do pytest command line arguments for this?, have another CI flag maybe. In that case i don't think there would be any hardcoding, although it would still change conftest. Looking forward to your thoughts.

IMO it's not a question of if we can, but if we should. As I said, support for utilising Redis databases is an inherently mystifying feature, where this repo is already mystifying enough heh. I really don't want to introduce things I don't understand, nor will probably ever care to understand.

asmeurer commented 2 years ago

Surely there must be a way to do this without modifying a project's specific conftest.py file. If there isn't, I would make an upstream request to the hypothesis project about it.