Closed asmeurer closed 1 year ago
This error actually occurs throughout the test suite, not just in the signature tests.
I think a simple fix would be if hypothesis only tried passing a tuple to
full
to avoid this issue.
Not a big fan of changes like this, where hypothesis.extra.array_api
is nominally built with the mindset to happily do whatever the spec allows (such as passing ints as the shape arg). But given this is probably not going to change anytime soon for pytorch, most likely a worthy change beyond just for this test suite, so I'll submit a patch.
For onlookers, ideally we could fallback to using inspect
, but alas
so we instead pass arrays for un-inspectable functions. They could be manual examples, but at the time I found it convenient to use Hypothesis, as it could easily translate a functions valid input dtypes and create an array from that... using manual examples could be revisited too, esp. if there's some blocker to changing Hypothesis behaviour.
This was discussed on slack. There are errors like
which are not easy to read
The problem is that hypothesis tries to pass an integer to
full
, but torch only supports a tuple. I think a simple fix would be if hypothesis only tried passing a tuple tofull
to avoid this issue.