search

data-apis / array-api-tests

Test suite for the PyData Array APIs standard
https://data-apis.org/array-api-tests/
MIT License
63 stars 39 forks source link

`linalg.cholesky` not tested for complex dtypes #228

Open lucascolley opened 8 months ago

lucascolley commented 8 months ago

As reported in https://github.com/data-apis/array-api-compat/pull/61#issuecomment-1875887990, linalg.cholesky is only tested on real arrays, hence some bugs slipped through into both array-api-compat and numpy.array_api.

lucascolley commented 3 months ago

relevant lines: https://github.com/data-apis/array-api-tests/blob/d295a0a66cd82a43e84c1b8d73ca198cc45e9d23/array_api_tests/test_linalg.py#L126-L130 https://github.com/data-apis/array-api-tests/blob/d295a0a66cd82a43e84c1b8d73ca198cc45e9d23/array_api_tests/hypothesis_helpers.py#L314