data-apis / array-api

RFC document, tooling and other content related to the array API standard
https://data-apis.github.io/array-api/latest/
MIT License
211 stars 44 forks source link

Revise guidance to require a minimum upper bound for supported ranks #702

Closed kgryte closed 10 months ago

kgryte commented 11 months ago

This PR

Related

kgryte commented 11 months ago

cc @leofang @Zac-HD

Zac-HD commented 11 months ago

If array libraries have a consistent way to retrieve the maximum dimensionality they support, Hypothesis can provide more informative error messages. iirc Numpy has a MAX_DIMS constant somewhere...

kgryte commented 11 months ago

@Zac-HD Indeed, that is part of the rationale behind https://github.com/data-apis/array-api/issues/694. Once we merge the inspection API in, we'll add support for querying the maximum number of allowed dimensions.

rgommers commented 10 months ago

This is pretty straightforward. I'll aim to merge this in a few days unless an objection appears.

kgryte commented 10 months ago

As this PR has received multiple approvals and no objections, will go ahead and merge. Any further changes can be addressed in follow-up PRs...