data-apis / array-api

RFC document, tooling and other content related to the array API standard
https://data-apis.github.io/array-api/latest/
MIT License
205 stars 42 forks source link

Add `hypot` specification for computing the square root of the sum of squares #703

Closed kgryte closed 4 months ago

kgryte commented 8 months ago

This PR

leofang commented 7 months ago

I am a bit concerned about mentioning subnormal here. In CuPy we always set the compiler flag -ftz=true which would flush all denormals to zero. This helps significantly with floating point operations on GPU. Would this PR imply that we can no longer do this?

leofang commented 4 months ago

Q: I forgot what conclusion we had on this API, @kgryte do we plan to target v2023?

kgryte commented 4 months ago

@leofang I've added a note concerning subnormal behavior and the fact that actual hardware support may vary. Does this allay your concerns?

rgommers commented 4 months ago

Great, looks like everyone is happy now - let's hit the green button. Thanks @kgryte & reviewers!